-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to NAN #44
Comments
Is this a launch task? I can help here - got fairly comfy with NaN on s2 |
Not seeing this as necessary for launch, but I'd like to hit it sooner rather than later. Would love some help if you've got time to dig into this @tmcw! |
Added multi-node branch to test, description of 0.12 changes is over at https://github.com/joyent/node/wiki/API-changes-between-v0.10-and-v0.12 |
Might be worth adding 0.8 too if it looks easy. |
Weird: so I got v0.11.x to try to compile, but it looks like the errors are in the node_mapnik source rather than node-fontnik: https://travis-ci.org/mapbox/node-fontnik/jobs/27250909#L1185 /cc @springmeyer |
thats not node-mapnik, but rather just looks like it because I think @mikemorris pulled in some node-mapnik headers. |
@tmcw @springmeyer I only pulled in
|
@tmcw Maybe drop |
k, will do |
Port to NAN to develop against both Node v0.10.x and v0.12.x. Some potentially helpful porting details at mapnik/node-mapnik#256.
The text was updated successfully, but these errors were encountered: