Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cropped last row #42

Closed
boris-ulyanov opened this issue Dec 30, 2021 · 3 comments
Closed

Cropped last row #42

boris-ulyanov opened this issue Dec 30, 2021 · 3 comments
Labels
question

Comments

@boris-ulyanov
Copy link
Contributor

Hi!

I noticed that bottom row of the bitmap is cropped for all characters:

original

Did not understand where the error, but if increase glyphHeight by one on line https://github.com/mapbox/tiny-sdf/blob/main/index.js#L59 :

fixed

Checked on chrome/firefox windows/linux/android
@mourner
Copy link
Member

mourner commented Dec 30, 2021

I thought this was already fixed by #33, are you sure this is reproducible with the latest version of TinySDF? I don't see it clipped on the current demo: https://mapbox.github.io/tiny-sdf/

@boris-ulyanov
Copy link
Contributor Author

Strange, right now I see this on the demo page (on default params):

demo2

Same result reproduced local on latest version

boris-ulyanov added a commit to boris-ulyanov/tiny-sdf that referenced this issue Jan 7, 2022
@boris-ulyanov
Fix glyph clipping at the bottom/2 mapbox#42
07a94ce
mourner pushed a commit that referenced this issue Feb 1, 2022
@boris-ulyanov
Fix glyph clipping at the bottom/2 #42 (#43)
05da1b2
@mourner
Copy link
Member

mourner commented Feb 1, 2022

Fixed by #43?

@mourner mourner closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mourner @boris-ulyanov