Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glyph clipping at the bottom/2 #42 #43

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Fix glyph clipping at the bottom/2 #42 #43

merged 1 commit into from
Feb 1, 2022

Conversation

boris-ulyanov
Copy link
Contributor

No description provided.

@boris-ulyanov
Copy link
Contributor Author

Example for illustration

Symbol = (all parameters are default)

actualBoundingBoxAscent = 12 
actualBoundingBoxDescent = -4
glyphTop = 12
glyphHeight = 8

After the line
imgData = ctx.getImageData(...)

imgData.data contains pixels:

in original version:
pre

after fix:
aft

@mourner mourner merged commit 05da1b2 into mapbox:main Feb 1, 2022
@mourner mourner mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boris-ulyanov @mourner