Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for coordinate saving #279

Closed
rwood-97 opened this issue Oct 26, 2023 · 0 comments · Fixed by #326
Closed

Add tests for coordinate saving #279

rwood-97 opened this issue Oct 26, 2023 · 0 comments · Fixed by #326
Labels
download Issues related to the "Download" functionality enhancement New feature or request new feature

Comments

@rwood-97
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I have just merged #276 since it's quite important to get it fixed.
Would be good to add tests to go with this to ensure that if anything changes in the future we still save coordinates as expected. This could probably be done using a couple of known coordinates to check against (like a control points).

Describe the solution you'd like
Add tests for coordinate saving.
@rwood-97 rwood-97 added enhancement New feature or request new feature labels Oct 26, 2023
@rwood-97 rwood-97 added the download Issues related to the "Download" functionality label Oct 26, 2023
@rwood-97 rwood-97 mentioned this issue Dec 7, 2023
Merged
@rwood-97 rwood-97 moved this from Upcoming to In progress (now) in MapReader Project Board -- legacy Dec 14, 2023
@rwood-97 rwood-97 mentioned this issue Dec 14, 2023
Merged
4 tasks
@rwood-97 rwood-97 closed this as completed Jan 8, 2024
@github-project-automation github-project-automation bot moved this from In progress (now) to Done in MapReader Project Board -- legacy Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
download Issues related to the "Download" functionality enhancement New feature or request new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for coordinate saving when downloading maps maps-as-data/MapReader
1 participant
@rwood-97