Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coordinate saving #276

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Fix coordinate saving #276

merged 3 commits into from
Oct 26, 2023

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Oct 26, 2023

Summary

This PR ensures that coordinates of the downloaded maps are saved correctly.

image
When downloading tiles, the coordinates of the tile at (1,1) correspond to the bottom left corner of the tile. This is the same as the upper right corner of tile (0,0).

If tile (3,3) makes up the upper right corner of the map image we have downloaded, then the coordinate of the upper right corner of the map image is not the coordinate (3,3) but actually (4,4).
This needed updating in the code as the coordinates that were previously saved were off by one tile index.

Describe your changes

Coordinates of NE corner of the map is now tile index +1 .

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@rwood-97 rwood-97 merged commit 8fdb38d into main Oct 26, 2023
2 checks passed
@rwood-97 rwood-97 deleted the dev_download branch October 26, 2023 13:00
@rwood-97 rwood-97 added the bug Something isn't working label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant