Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for coordinate saving when downloading maps #326

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Dec 14, 2023

Summary

This PR adds tests for coordinate saving.
These coords have been checked by saving maps as geotiffs and comparing in QGIS against an OSM basemap.

Fixes #279

This PR should be merged after #318 as it has taken some changes from there.
git merge main before merging this PR.

Describe your changes

  • Coords are tested for both zoom level 10 and 14.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@rwood-97 rwood-97 changed the base branch from main to dev January 5, 2024 15:27
@rwood-97 rwood-97 marked this pull request as ready for review January 5, 2024 16:08
@rwood-97 rwood-97 merged commit 8cd9572 into dev Jan 5, 2024
3 checks passed
@rwood-97 rwood-97 deleted the 279-test-coord-saving branch January 5, 2024 16:19
@rwood-97 rwood-97 mentioned this pull request Jan 5, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for coordinate saving
1 participant