-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update geojson and geotiff saving #318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 56.45% 58.69% +2.24%
==========================================
Files 35 35
Lines 5875 6092 +217
==========================================
+ Hits 3317 3576 +259
+ Misses 2558 2516 -42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the moment, the code can output patches as geojson and geotiffs. These methods rely on coordinates being saved in the patch/parent metadata.
Problems with this come from:
[minx, miny, maxx, maxy]
) so when reading from a csv, these coords are read as a string and not a python list object. This is a problem when indexing the coord list later on.Describe your changes
This PR:
literal_eval
to all columns in dataframe using try/except. This fixes problems with tuples/coordinates/etc being read as strings. i.e. fixes problem with coords list.Checklist before assigning a reviewer (update as needed)
To do:
save_parents_as_geotiffs()
Reviewer checklist
Please add anything you want reviewers to specifically focus/comment on.