[miio] Add temperature value to chuangmi.plug.v1 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see in other projects this plug does also support temperature: https://github.com/syssi/xiaomiplug/blob/develop/README.md#xiaomi-chuangmi-plug-v1 https://github.com/rytilahti/python-miio/blob/master/miio/chuangmi_plug.py#L23 Signed-off-by: Jeroen Vermeulen <info@jeroenvermeulen.eu>
|
cool, |
|
Yes you can do it, I am not so familiar with contributing to the OpenHAB project, and the rules seem to be quite strict. |
Travis tests were successfulHey @jeroenvermeulen, |
marcelrv
added a commit
that referenced
this pull request
Oct 21, 2020
Based on: #12 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added a commit
that referenced
this pull request
Oct 21, 2020
Based on: #12 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
kaikreuzer
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Oct 22, 2020
Based on: marcelrv#12 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added a commit
that referenced
this pull request
Oct 24, 2020
Based on: #12 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
cpmeister
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Oct 24, 2020
* [miio] delay refresh to avoid devices not ready yet (#8838) * [miio] delay refresh to avoid devices not ready yet Delay refresh after command is send as some devices are not ready yet with the execution and will report wrong status. This is confusing to the users. Related forum topic: https://community.openhab.org/t/xiaomi-mi-air-purifier-xiaomi-mi-io/34840/300 * [miio] remove change from PR * [miio] Add temperature value to chuangmi.plug.v1 (#8832) Based on: marcelrv#12 * [miio] add new country server and improve readme (#8816) * [miio] add new country server and improve readme * [miio] apply spotless * [miio] Allow for custom refresh commands (#8796) * [miio] Allow for custom refresh commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
Based on: marcelrv#12 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio
pushed a commit
to marcfischerboschio/openHABaddon
that referenced
this pull request
Apr 20, 2022
Based on: marcelrv/openhab-addons#12 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[miio] Add temperature value to chuangmi.plug.v1
I see in other projects this plug does also support temperature:
https://github.com/syssi/xiaomiplug/blob/develop/README.md#xiaomi-chuangmi-plug-v1
https://github.com/rytilahti/python-miio/blob/master/miio/chuangmi_plug.py#L23