[miio] Allow for custom refresh commands #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow for custom commands during miio:basic refreshes, needed to support refresh for e.g. scicoffeemaker, viomi vacuums etc * Improve the unsupported handler to deal with the custom commands as well * Do not add non-existing channeltypes in basic handler * Add the right channeltypes to the jsonDB instead of just defaulting them to the channel names. Signed-off-by: Marcel Verpaalen marcel@verpaalen.com
marcelrv
added
the
enhancement
Travis tests were successfulHey @marcelrv, |
cpmeister
requested changes
Oct 20, 2020
...b.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoBasicHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoBasicHandler.java
Show resolved
Hide resolved
…ding/miio/internal/handler/MiIoBasicHandler.java Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
cpmeister
reviewed
Oct 21, 2020
| "readmeComment": "If this channel does not respond to on/off replace the model with chuangmi.plug.v3old in the config or upgrade firmware" | ||
| }, | ||
| { | ||
| "property": "usb_on", |
There was a problem hiding this comment.
Also, why did the formatting change for this file? It is not inconsistent with the other files.
There was a problem hiding this comment.
I used that file for my testing, and did some intrim reset to undo my changes for the testing.
seems that that also undone the formatting changes...
Applied the formatter once more.
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added a commit
to marcelrv/openhab-addons
that referenced
this pull request
Oct 24, 2020
* [miio] Allow for custom refresh commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
cpmeister
pushed a commit
that referenced
this pull request
Oct 24, 2020
* [miio] delay refresh to avoid devices not ready yet (#8838) * [miio] delay refresh to avoid devices not ready yet Delay refresh after command is send as some devices are not ready yet with the execution and will report wrong status. This is confusing to the users. Related forum topic: https://community.openhab.org/t/xiaomi-mi-air-purifier-xiaomi-mi-io/34840/300 * [miio] remove change from PR * [miio] Add temperature value to chuangmi.plug.v1 (#8832) Based on: marcelrv#12 * [miio] add new country server and improve readme (#8816) * [miio] add new country server and improve readme * [miio] apply spotless * [miio] Allow for custom refresh commands (#8796) * [miio] Allow for custom refresh commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
* [miio] Allow for custom refresh commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [miio] Allow for custom refresh commands Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for custom commands during miio:basic refreshes, needed to
support refresh for e.g. scicoffeemaker, viomi vacuums etc
Improve the unsupported handler to deal with the custom commands as
well
Do not add non-existing channeltypes in basic handler
Add the right channeltypes to the jsonDB instead of just defaulting
them to the channel names.
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com