Skip to content

Commit

Permalink
Bug 1919940 [wpt PR 48214] - DOM: Implement async iterable conversion…
Browse files Browse the repository at this point in the history
… support for Observables, a=testonly

Automatic update from web-platform-tests
DOM: Implement async iterable conversion support for Observables

This CL implements async iterator support for Observables, and adds tons
of WPTs exercising subtle functionality of iterable and async iterable
Observable conversion semantics. It implements the spec text in
WICG/observable#160, and is a follow-up to
https://crrev.com/c/5840672, which brings async iterable support to core
bindings code.

This CL amounts to a partial implementation of async iterable support;
what's missing and what will be included as a follow-up is:

 1. Support for calling the Async Iterator's `return()` method [1] when
    an Observable — when consuming an async iterable — aborts its
    subscription before iterable exhaustion.
 3. A possible refactor to move some of the logic that handles the
    `ScriptIterator` into `ScriptIterator` itself, per discussion in
    [2].

[1]: https://tc39.es/ecma262/#sec-asynciterator-interface
[2]: https://chromium-review.googlesource.com/c/chromium/src/+/5840672/comment/72df95a9_dd32d801/

R=masonfchromium.org

Bug: 40282760, 363015168
Change-Id: I5f31f4028613245025de71b8975fc92e9d1def0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5850509
Reviewed-by: Mason Freed <masonfchromium.org>
Commit-Queue: Dominic Farolino <domchromium.org>
Cr-Commit-Position: refs/heads/main{#1356228}

--

wpt-commits: 4b27fc79b6ce4edaf1d6a8c0072bd71fce62a6b2
wpt-pr: 48214

UltraBlame original commit: 2a63fcd3013866bf2a31144f3dd0fa10b96130ac
  • Loading branch information
marco-c committed Sep 25, 2024
1 parent 3043ce4 commit 5826ace
Showing 1 changed file with 2,975 additions and 0 deletions.
Loading

0 comments on commit 5826ace

Please sign in to comment.