Bug 1800077 - Make <input type=button> magic clip not magic. r=jwatt,…

…zcorpan

This implements the proposal in:

  whatwg/html#9976

Will wait till that is settled to land this.

MANUAL PUSH: See bug 1871425

Differential Revision: https://phabricator.services.mozilla.com/D195419

UltraBlame original commit: 1fb09caf9d62bdc3b7449621fa8a8deb132a1070

layout/forms/nsGfxButtonControlFrame.h

@@ -343,17 +343,6 @@ nsString
 aLabel
 )
 ;
-virtual
-bool
-IsInput
-(
-)
-override
-{
-return
-true
-;
-}
 private
 :
 RefPtr

layout/forms/nsHTMLButtonControlFrame.cpp

@@ -156,13 +156,6 @@ h
 #
 include
 "
-nsIFrameInlines
-.
-h
-"
-#
-include
-"
 nsPresContext
 .
 h
@@ -184,20 +177,6 @@ h
 #
 include
 "
-nsCSSAnonBoxes
-.
-h
-"
-#
-include
-"
-nsNameSpaceManager
-.
-h
-"
-#
-include
-"
 nsDisplayList
 .
 h
@@ -451,12 +430,25 @@ ShouldClipPaintingToBorderBox
 (
 )
 {
-return
-IsInput
+/
+/
+FIXME
 (
+emilio
 )
-|
-|
+:
+probably
+should
+account
+for
+per
+-
+axis
+clipping
+.
+.
+.
+return
 StyleDisplay
 (
 )

layout/forms/nsHTMLButtonControlFrame.h

@@ -517,16 +517,6 @@ ClassID
 aID
 )
 ;
-virtual
-bool
-IsInput
-(
-)
-{
-return
-false
-;
-}
 /
 /
 Indicates

layout/reftests/css-grid/grid-item-overflow-stretch-005-ref.html

@@ -242,6 +242,8 @@
 os
 .
 oh
+.
+ov
 {
 width
 :
@@ -264,6 +266,10 @@
 m
 .
 oh
+.
+m
+.
+ov
 {
 width
 :

layout/style/res/forms.css

@@ -3109,6 +3109,16 @@ select
 :
 none
 ;
+overflow
+-
+clip
+-
+box
+:
+padding
+-
+box
+;
 }
 /
 *
@@ -3185,16 +3195,6 @@ align
 :
 center
 ;
-overflow
--
-clip
--
-box
-:
-padding
--
-box
-;
 padding
 -
 inline
@@ -3226,6 +3226,54 @@ padding
 4px
 ;
 }
+/
+*
+https
+:
+/
+/
+github
+.
+com
+/
+whatwg
+/
+html
+/
+issues
+/
+9976
+*
+/
+input
+:
+not
+(
+[
+type
+=
+image
+i
+]
+)
+{
+overflow
+:
+clip
+!
+important
+;
+overflow
+-
+clip
+-
+margin
+:
+0px
+!
+important
+;
+}
 button
 :
 :

layout/style/test/test_dynamic_change_causing_reflow.html

@@ -438,6 +438,11 @@
 "
 inputElem
 "
+type
+=
+"
+image
+"
 >
 <
 textarea