-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[forms] Make <input type=button> magic clip not magic #9976
Comments
cc @zcorpan |
The current text says https://html.spec.whatwg.org/#form-controls
Would vertical-align be affected by changing to 'clip'? cc @whatwg/rendering |
I don't think so, no. |
And clearly given the bugs linked above the overflow property isn't completely ignored, either... |
https://www.w3.org/TR/CSS22/visudet.html#propdef-vertical-align
My understanding is that if the computed value of 'overflow' is 'clip' then the baseline is the bottom margin edge, which isn't what we want for buttons (or form controls in general). https://html.spec.whatwg.org/#form-controls has
Maybe the spec for vertical-align could be changed so that form controls are exempt from the baseline change based on 'overflow'? |
Demo: https://software.hixie.ch/utilities/js/live-dom-viewer/saved/12199 It seems WebKit/Chromium/Gecko don't honor CSS 2.2 wrt the above-quoted text about where the baseline should be. (WebKit and Chromium also use the first line instead of the last line for multi-line buttons, but that's a separate issue.) |
CSS2 is not the thing to follow here, see w3c/csswg-drafts#6212. |
Ah, thanks! Then yes, I think switching to The only change to the suggested CSS in OP would be to use the |
type is case insensitive in html elements iirc, but doesn't hurt to be explicit I guess |
This seems like a reasonable change to me. If I'm reading the comments correctly, changing to |
The previous prose to make `overflow` act as `visible` with regards to other CSS features but still clip didn't work well with e.g. `text-overflow: ellipsis`. CSS now has a standard way to do what `input` buttons need, i.e. clip and also not affect interaction with `vertical-align`. Fixes #9976.
Add pagereveal event The pagereveal event is fired at the beginning of the first rendering opportunity after activation (initial load or reactivation). It is a way for the author to execute some JS that affects the presentation "just in time" for the first frame. If there is an inbound cross-document view transition, the reveal event holds a reference to the ViewTransition object. Closes whatwg#9315. Use UA styles rather than prose to define <input> clip The previous prose to make `overflow` act as `visible` with regards to other CSS features but still clip didn't work well with e.g. `text-overflow: ellipsis`. CSS now has a standard way to do what `input` buttons need, i.e. clip and also not affect interaction with `vertical-align`. Fixes whatwg#9976. Forbid nesting <details> in the same exclusive accordion Fixes whatwg#9968.
This implements the proposal in: whatwg/html#9976 Will wait till that is settled to land this. MANUAL PUSH: See bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1800077 gecko-commit: 1fb09caf9d62bdc3b7449621fa8a8deb132a1070 gecko-reviewers: jwatt, zcorpan
This implements the proposal in: whatwg/html#9976 MANUAL PUSH: see bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1800077 gecko-commit: 6a14f603289807a62753cc8ceaa35d9ba09cbf61 gecko-reviewers: jwatt, zcorpan
…zcorpan This implements the proposal in: whatwg/html#9976 Will wait till that is settled to land this. MANUAL PUSH: See bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419
…zcorpan This implements the proposal in: whatwg/html#9976 MANUAL PUSH: see bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419
This implements the proposal in: whatwg/html#9976 MANUAL PUSH: see bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1800077 gecko-commit: 6a14f603289807a62753cc8ceaa35d9ba09cbf61 gecko-reviewers: jwatt, zcorpan
…zcorpan This implements the proposal in: whatwg/html#9976 Will wait till that is settled to land this. MANUAL PUSH: See bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419
…zcorpan This implements the proposal in: whatwg/html#9976 MANUAL PUSH: see bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419
chrome issue for this: https://bugs.chromium.org/p/chromium/issues/detail?id=1513949 ah nevermind, we already have this: https://bugs.chromium.org/p/chromium/issues/detail?id=1383144 |
…zcorpan This implements the proposal in: whatwg/html#9976 Will wait till that is settled to land this. MANUAL PUSH: See bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 UltraBlame original commit: 1fb09caf9d62bdc3b7449621fa8a8deb132a1070
…zcorpan This implements the proposal in: whatwg/html#9976 MANUAL PUSH: see bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 UltraBlame original commit: 6a14f603289807a62753cc8ceaa35d9ba09cbf61
…zcorpan This implements the proposal in: whatwg/html#9976 Will wait till that is settled to land this. MANUAL PUSH: See bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 UltraBlame original commit: 1fb09caf9d62bdc3b7449621fa8a8deb132a1070
…zcorpan This implements the proposal in: whatwg/html#9976 MANUAL PUSH: see bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 UltraBlame original commit: 6a14f603289807a62753cc8ceaa35d9ba09cbf61
…zcorpan This implements the proposal in: whatwg/html#9976 Will wait till that is settled to land this. MANUAL PUSH: See bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 UltraBlame original commit: 1fb09caf9d62bdc3b7449621fa8a8deb132a1070
…zcorpan This implements the proposal in: whatwg/html#9976 MANUAL PUSH: see bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 UltraBlame original commit: 6a14f603289807a62753cc8ceaa35d9ba09cbf61
I always thought |
This implements the proposal in: whatwg/html#9976 MANUAL PUSH: see bug 1871425 Differential Revision: https://phabricator.services.mozilla.com/D195419 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1800077 gecko-commit: 6a14f603289807a62753cc8ceaa35d9ba09cbf61 gecko-reviewers: jwatt, zcorpan
What is the issue with the HTML Standard?
<input type=button>
forcesoverflow: clip
on their contents, but "magically".I propose we remove that magic and instead add:
To the UA stylesheet in the spec here.
That would allow other features like
text-overflow: ellipsis
to also work, see https://bugzilla.mozilla.org/show_bug.cgi?id=1800077 / https://bugs.chromium.org/p/chromium/issues/detail?id=1383144.The text was updated successfully, but these errors were encountered: