Remove binaries by name #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosnils
reviewed
Mar 5, 2021
cristiand391
commented
Mar 6, 2021
marcosnils
approved these changes
Mar 9, 2021
marcosnils
added a commit
that referenced
this pull request
Mar 15, 2021
* Add Exe matcher for Windows releases. * fix docker sh command on Windows * initialize sample scenarios based on OS * add comments to cases definition Ignore the vscode devcontainer configuration * Revert "add comments to cases definition" This reverts commit 94cb6e6. * Revert "initialize sample scenarios based on OS" This reverts commit 0b639e1. * Allow to mock OS and Arch for asset filtering tests * Remove binaries by name (#48) * Remove binaries by name * Reuse logic for finding binary path * make getBinPath check if arg is a path Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com> * add resolvers and test cases * Add Exe matcher for Windows releases. * fix docker sh command on Windows * add resolvers and test cases Co-authored-by: Roberto Ferrer <r.ferrer@innovation.es> Co-authored-by: Marcos Lilljedahl <marcosnils@gmail.com> Co-authored-by: Cristian Dominguez <6853656+cristiand391@users.noreply.github.com> Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com> Co-authored-by: Sune Keller <sune.keller+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #43 (comment)
This PR adds support for removing binaries by name.