Fix bug in finding path to ./git/log/HEAD if Marian is a submodule. #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone might want to maintain different build directories for different configurations, so build_info.cpp needs to be created in the build directory, not in the source directory, as it pertains to cmake options, not actual source code.
…t/marian-dev into ug-marian-as-submodule
|
Fixes #645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in determining the location of .git/log/HEAD when Marian is a submodule in
another project.
List of changes:
How to test
add Marian as a submodule in another project, add_subdirs(where/marian/is/located) and run cmake for the parent project.
Checklist