Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in finding path to ./git/log/HEAD if Marian is a submodule. #644

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Fix bug in finding path to ./git/log/HEAD if Marian is a submodule. #644

merged 5 commits into from
Jul 21, 2020

Commits on Apr 28, 2020

  1. Fix bug in finding path to ./git/log/HEAD if Marian is a submodule.

    @ugermann
    ugermann committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    99dd838 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @ugermann
    ugermann authored Apr 28, 2020
    Configuration menu
    Copy the full SHA
    305d1d3 View commit details
    Browse the repository at this point in the history

  3. Build build_info.cpp in build dir, not source dir. 

    Someone might want to maintain different build directories for
different configurations, so build_info.cpp needs to be created
in the build directory, not in the source directory, as it pertains
to cmake options, not actual source code.
    @ugermann
    ugermann committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    0b688c7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'ug-marian-as-submodule' of https://github.com/marian-nm… 

    …t/marian-dev into ug-marian-as-submodule
    @ugermann
    ugermann committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    1b5f687 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.md

    @ugermann
    ugermann authored Apr 28, 2020
    Configuration menu
    Copy the full SHA
    57c738f View commit details
    Browse the repository at this point in the history