Expose named exports for ESM build

[benmccann]

Marked version:

Tested against 3.0.4

Markdown flavor: all

Description

Currently, you can only used named exports from the CJS build. This will write them in such a way that Rollup can figure out they're exposed and should be exported in the ESM build as well.

Expectation

I should be able to do import { parse } from 'marked';. I expect lib/marked.esm.js to export the parse method

Result

Today I get:

'parse' is not exported by 'node_modules/.pnpm/marked@3.0.4/node_modules/marked/lib/marked.esm.js'

That's because lib/marked.esm.js only has a default export

What was attempted

I tried to do import { parse } from 'marked';

Contributor

• Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
• no tests required for this PR.
• If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

• CI is green (no forced merge required).
• Squash and Merge PR following conventional commit guidelines.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/Gv3eqhvsrkpvPKFwfsounN2FhTLf
✅ Preview: https://markedjs-git-fork-benmccann-named-exports-markedjs.vercel.app

[Conduitry]

Would it be a good idea to add a pkg.exports map at the same time, so that native Node ESM consumers (not using a bundler) will also get the ESM version rather than the CJS version?

[benmccann]

There's a pending PR for it: #1725. Maybe not a bad idea, but I'd prefer to do it in a separate PR to keep this one simpler

[Conduitry]

Yup, makes sense.

[benmccann]

Thanks for the approval @UziTech! Just curious, is there anything else needed before this can be merged?

[UziTech]

I think this looks good. On marked we want 2 approvals for each PR so we are just waiting on someone else in the markedjs org to approve it.

[github-actions]

🎉 This PR is included in version 3.0.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[splch]

This update broke my website's markdown renderer. I'm getting a "marked.setOptions is not a function" error.
https://slc.is

[UziTech]

it seems like this change changed lib/marked.js into an ES Module

[Conduitry]

https://unpkg.com/marked@3.0.5/lib/marked.js It certainly doesn't look like that's what happened.

[UziTech]

Object.defineProperty(exports, '__esModule', { value: true });

[UziTech]

@splch you should set a version on your dependencies so they don't break automatically.

[splch]

For sure, I just like using the latest for development purposes so I tend to leave them unspecified.

[benmccann]

Here's a fix for the issue: #2226