Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emphasis syntax regression (?) #641

Closed
cheesypoof opened this issue Aug 10, 2015 · 2 comments
Closed

Emphasis syntax regression (?) #641

cheesypoof opened this issue Aug 10, 2015 · 2 comments

Comments

@cheesypoof
Copy link

In v0.3.3 _**ABC\_DEF**_ generates <em><strong>ABC_DEF</strong></em>
In v0.3.4 _**ABC\_DEF**_ generates _<strong>ABC_DEF</strong>_

Regression?
ariabuckles added a commit to ariabuckles/simple-markdown that referenced this issue Feb 1, 2016
@ariabuckles
em: Allow escaped underscores in em again
9504ca5 
This was a regression in 0.0.8.

See [this marked.js issue](markedjs/marked#641).

Test plan: `make test`
ariabuckles added a commit to ariabuckles/marked that referenced this issue Feb 1, 2016
@ariabuckles
em: Allow escaped underscores in em again
fa1495c 
This was a regression in 0.3.4

See issue markedjs#641

Test plan:

In node, run

```javascript
var marked = require("./lib/marked.js");
marked.parse("_ABC\\_DEF_")
> '<p><em>ABC_DEF</em></p>\n'
```

Previously, this would give '<p>_ABC_DEF_</p>\n'
@ariabuckles ariabuckles mentioned this issue Feb 1, 2016
Closed
@ariabuckles
Copy link

I believe this change is from the em tag's security fix in 0.3.4. I think it's possible to fix this specific case (escaped underscores) without reintroducing that error.

I've fixed this in my marked-derived parser at ariabuckles/simple-markdown@9504ca5 and sent pull request #715 to marked

ariabuckles added a commit to ariabuckles/marked that referenced this issue Feb 1, 2016
@ariabuckles
em: Allow escaped underscores in em again
fe7eaab 
This was a regression in 0.3.4

See issue markedjs#641

Test plan:

In node, run

```javascript
var marked = require("./lib/marked.js");
marked.parse("_ABC\\_DEF_")
> '<p><em>ABC_DEF</em></p>\n'
```

Previously, this would give '<p>_ABC_DEF_</p>\n'
@Feder1co5oave Feder1co5oave mentioned this issue Jan 25, 2018
Closed
8 tasks
@joshbruce
Copy link
Member

Closing as most likely covered by spec compliance. See also #1106 and #1216.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ariabuckles @cheesypoof @joshbruce