Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

em: Allow escaped underscores in em again #715

Closed
wants to merge 1 commit into from

Conversation

ariabuckles
Copy link

This was a regression in 0.3.4

See issue #641

Test plan:

In node, run

var marked = require("./lib/marked.js");
marked.parse("_ABC\\_DEF_")
> '<p><em>ABC_DEF</em></p>\n'

Previously, this would give '<p>_ABC_DEF_</p>\n'

This was a regression in 0.3.4

See issue markedjs#641

Test plan:

In node, run

```javascript
var marked = require("./lib/marked.js");
marked.parse("_ABC\\_DEF_")
> '<p><em>ABC_DEF</em></p>\n'
```

Previously, this would give '<p>_ABC_DEF_</p>\n'
@ariabuckles
Copy link
Author

Update: forgot to build the minified version, and forgot to do [\s\S] instead of _ after the backslash :/. I updated the commit.

@joshbruce
Copy link
Member

See #1010

Closing due to merge conflicts, stale, and missing tests.

@joshbruce joshbruce closed this Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants