Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The organizer's e-mail changes the @ to %40 #434

Closed
xCamacho91 opened this issue Jul 8, 2022 · 2 comments · Fixed by #479
Closed

The organizer's e-mail changes the @ to %40 #434

xCamacho91 opened this issue Jul 8, 2022 · 2 comments · Fixed by #479

Comments

@xCamacho91
Copy link

xCamacho91 commented Jul 8, 2022 •
edited
Loading

When the organizer's email is set and after urlencode($this->emailAddress) it is turning the @ into %40, do you have any way around this?
@xCamacho91 xCamacho91 changed the title The organizer's email is changing the @ to %40 The organizer's e-mail changes the @ to %40 Jul 8, 2022
@JorisDebonnet
Copy link

I also had this issue. It also happens with the new Attendees feature.

The problem is the EmailAddress:toUri method which replaces the @ by %40.

I temporarily "fixed" this by simply replacing %40 back to @ in my final output, but of course that's not ideal. Perhaps when I have more time I'll create a PR, although anyone else also could.

This was referenced Sep 29, 2022
Closed
Closed
markuspoerschke added a commit that referenced this issue Dec 23, 2022
@markuspoerschke
Fix EmailAddress value object
fd96467 
Do not url encode email addresses.

Fixes #444
Fixes #434
Fixes #390
@markuspoerschke markuspoerschke mentioned this issue Dec 23, 2022
Merged
@markuspoerschke
Copy link
Owner

Thanks for raising this issue.

This bug will be fixed in #479.

markuspoerschke added a commit that referenced this issue Dec 23, 2022
@markuspoerschke
Fix email address (#479)
7b9379b 
Do not url encode email addresses.

Fixes #444
Fixes #434
Fixes #390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix email address markuspoerschke/iCal
Update EmailAddress.php JorisDebonnet/iCal
3 participants
@markuspoerschke @JorisDebonnet @xCamacho91