Update EmailAddress.php

[JorisDebonnet]

Several email/calendar clients do not support %40 in place of @ in email addresses. For example, EmClient will show "nobody@invalid.invalid" instead of the actual email address. Also some other clients may work but show the %40 in plain text instead of converting it to @, confusing users.

So let's just not replace @ with %40. 😊

Fixes #434

[Bapawe]

We've had a similar issue where users could not import the ics file (with encoded emails in Organizer and Attendee) in Outlook 2016. After applying this fix they could import the ics file again.

[navarr]

This is a decent solution for most occurences of the issue, and while I'm not sure if its important enough - this would ironically destroy an email of user-with-%40-in-their-address@domain.tld which is seemingly a valid email address.

A better solution might be to require a properly formatted email address and do no escaping to it, or otherwise force the creation of an EmailAddress object that maintains a separate user and host that can be encoded separately. (Although, are subject, cc, body, and other mailto: parameters.

[JorisDebonnet]

This is a decent solution for most occurences of the issue, and while I'm not sure if its important enough - this would ironically destroy an email of user-with-%40-in-their-address@domain.tld which is seemingly a valid email address.

I understand what you mean, however, %40 us currently already being converted to %2540 because of the urlencode ... 😏

So although I agree this PR is not the best solution, it is better than it is now for many email clients.

Of course, if we can quickly find a better solution (with email validators or sanitizers), I would be fine with that of course, then there is no urgency in merging this PR :)

[markuspoerschke]

Thanks for raising this issue.

This bug will be fixed in #479.