Revert "Merge pull request #53 from jrjohnson/newline-description" #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a test is needed. |
|
I think this will be fixed with #60? |
|
Yes, bug is fixed with #60. But you still have the following issues:
Since you already merged #60, you can close my pull request. But I'd recommend fixing the two minor issues above. |
markuspoerschke
added a commit
that referenced
this pull request
Apr 4, 2017
|
@buergimi Thanks for your input. I fixed the issues you mentioned! 😃 |
markuspoerschke
added a commit
that referenced
this pull request
Apr 4, 2017
markuspoerschke
added a commit
that referenced
this pull request
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 340c634, reversing
changes made to 6ad1850.
the reverted commit did not fix multi-line descriptions, it broke it. When I remove this commit completely, multi-line descriptions work just fine.