Choices are translated even when SelectInput is a child of ReferenceInput

[fzaninotto]

What you were expecting:

Choices that are fetched from a reference (e.g. authors from a book) shouldn't be translated.

What happened instead:

They are translated, but as they use their value as default translation, this isn't visible unless you enable the missing translation warnings in the i18nProvider.

Steps to reproduce:

1. Open this Stackblitz, which is a fork of the simple example: https://stackblitz.com/edit/github-qm3anf
2. Go to the comment list
3. Click on the first comment to open the comment edition page
4. Click on the post dropdown to reveal the list of options
5. The fist option is 'ERROR'

The only modifications I made relative to the canonical simple example are:

1. Replace AutocompleteInput by SelectInput in the CommentEdit form
2. Add a translation for the string 'A voluptas eius eveniet ut commodi dolor' in the English messages

Related code:

This has to do with the translateChoices prop in choice inputs (SelectInput, AutocompleteInput, RadioButtonGrupoInput, CheckboxGrupInput, etc.). Its default value should be true, except when inside a Reference input.

This feature used to work in v3, when ReferenceInput cloned its child.

react-admin/packages/ra-ui-materialui/src/input/ReferenceInput.tsx

Line 261 in d295fc9

translateChoice: false,

It no longer works in v4, despite what's documented:

Note that translateChoice is set to false when <SelectInput> is a child of <ReferenceInput>.

Environment

• React-admin version: v4
• Last version that did not exhibit the issue (if applicable): v3
• React version: 17
• Browser: All