Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <SelectInput> translates choices even inside a <ReferenceInput> #9176

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Aug 11, 2023

Closes #9134

The problem occurs in all select inputs:

  • SelectInput
  • SelectArrayInput
  • AutocompleteInput
  • AutocompleteArrayInput
  • RadioButtonGroupInput
  • CheckboxGroupInput

To do

  • Fix the bug in all components
  • Add a story to check the translateChoice behavior in all components
  • Add unit tests

The doc doesn't need to be updated, as it already states that the choices aren't translated when inside ReferenceInput.

@adguernier adguernier merged commit 368403e into master Aug 11, 2023
@adguernier adguernier deleted the Fix-SelectInput-translates-choices-even-inside-a-ReferenceInput branch August 11, 2023 12:16
@adguernier adguernier added this to the 4.13.0 milestone Aug 11, 2023
@fzaninotto fzaninotto changed the title Fix SelectInput translates choices even inside a ReferenceInput Fix <SelectInput> translates choices even inside a <ReferenceInput> Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choices are translated even when SelectInput is a child of ReferenceInput
2 participants