Skip to content

Conversation

@WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Apr 21, 2025

Problem

Loading component is difficult to re-use because it has a hard-coded one second timeout inside of it.

Solution

Add a timeout prop default to one second to make it more flexible

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@fzaninotto
Copy link
Member

Thanks!

This is technically an evolution, though. Would you mind rebasing your PR on next?

@WiXSL WiXSL changed the base branch from master to next April 22, 2025 11:33
@WiXSL WiXSL changed the base branch from next to master April 22, 2025 11:33
@WiXSL WiXSL changed the base branch from master to next April 22, 2025 12:38
@WiXSL WiXSL changed the base branch from next to master April 22, 2025 12:39
@WiXSL WiXSL closed this Apr 22, 2025
@WiXSL WiXSL deleted the fix-loading-timeout branch April 22, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants