Skip to content

Conversation

@WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Apr 22, 2025

Problem

Loading component is difficult to re-use because it has a hard-coded one second timeout inside of it.

Supersedes #10687

Solution

Add a timeout prop default to one second to make it more flexible

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi merged commit 9606722 into marmelab:next Apr 23, 2025
15 checks passed
@djhi djhi added this to the 5.8.0 milestone Apr 23, 2025
@WiXSL WiXSL deleted the next-fix-loading-timeout branch April 23, 2025 13:08
@fzaninotto fzaninotto changed the title Fix Loading component timeout Add ability to tweak <Loading> timeout Apr 23, 2025
@fzaninotto fzaninotto changed the title Add ability to tweak <Loading> timeout Add ability to configure <Loading> timeout Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants