Introduce useResourceLabel hook #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
djhi
commented
Mar 8, 2021
•
djhi
commented
- Introduce hook
- Use the hook where possible (menu, page titles, etc.)
fzaninotto
requested changes
Mar 11, 2021
| const resources = useSelector(getResources); | ||
| const translate = useTranslate(); | ||
|
|
||
| return (resource: string, pluralize = true): string => { |
There was a problem hiding this comment.
Why is it a higher-order function and why isn't the hook simply returning the label? This needs to be explained in the jsDoc I think.
| * smart_count: 1, | ||
| * _: inflection.humanize(inflection.singularize(resource)), | ||
| * }); | ||
| * const resourceName = useResourceLabel(resource, false); |
There was a problem hiding this comment.
bad syntax: it returns a function
|
|
||
| /** | ||
| * A hook which will return a translated resource name. It will use the label option of the `Resource` component if provided. | ||
| * |
There was a problem hiding this comment.
could you add a usage example?
fzaninotto
requested changes
Mar 16, 2021
There was a problem hiding this comment.
Seing the code is use, I find the API perfectible. The second parameter, true, isn't very readable if one doesn't know the signature of the hook. Why not pass an options object instead?
-getResourceLabel(resource, true)
+getResourceLabel(resource, { smart_count: 1 })
|
needs rebase |
djhi
force-pushed
the
use-resource-label
branch
from
f07ae1c to
67cbcda
Compare
fzaninotto
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.