Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Inner page components depending on the context render more often than before, and are significantly slower.
Root cause analysis
The introduction of
useResourceLabel
in #6016 forced a rerender of each view whenever an action is dispatched. That's because this new hook depends on a bad selector that creates a new result each time it is called:react-admin/packages/ra-core/src/reducer/admin/resource/index.ts
Lines 77 to 78 in f8df1eb
Therefore, in each of the main page controller (
useListController
, etc.), any change in the Redux store forces a re-run of the controller, which returns a new object, which updates the page context, which forces a rerender of all the components depending on it.Solution
Do not use
useSelector
with that bad selector.Before
13 renders of the
<Datagrid>
component in the Post list view in the simple demo:After
7 renders of the
<Datagrid>
component in the Post list view in the simple demo: