[TypeScript] add setParams in ListContext #9340
Closed
+245
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In some situations you might want to change multiple parameters on the ListContext (ex: sort & filter). Currently, you have to call two methods: setFilter and setSort. However, this sometimes fail to apply both results and you loose one of them (Calling setSort and setFilters after one another filckers and doesn't setSort · Issue #4189 · marmelab/react-admin ). There are workaround but they are not always available (you can’t always use the navigation API, e.g ReferenceManyField)
Solution
Add a setParams function that accepts the getList payload pagination, sort and filter).
Make sure to update all components that implements ListContext (in enterprise too)
To be added in:
use ListController
useList
useReferenceManyFieldController
useReferenceArrayInputController
useReferenceManyInputController
useReferenceManyToManyInputController
…