Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setParams callback to ListContext #9638

Closed
wants to merge 3 commits into from
Closed

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Feb 3, 2024

Problem

In a <List>, it's not possible to set both the sort and filter simultaneously.

Solution

Introduce a new calback in ListContext, setParams, which lets users set all the params they want in one shot.

Closes #4189
Supersedes #9340

Todo

  • Basic implementation for List
  • Unit tests for List
  • Basic implementation for InfiniteList
  • Unit tests for InfiniteList
  • Basic implementation for useList
  • Unit tests for useList
  • Basic implementation for ReferenceManyField
  • Unit tests for ReferenceManyField
  • Basic implementation for ReferenceInput
  • Unit tests for ReferenceInput
  • Basic implementation for ReferenceArrayInput
  • Unit tests for ReferenceArrayInput
  • Add stories
  • Add documentation

Sorry, something went wrong.

@fzaninotto fzaninotto added the WIP Work In Progress label Feb 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@fzaninotto
Copy link
Member Author

As discussed in #4189, I now believe this change isn't necessary, as there is a simple workaround for the initial problem. We won't move forward with this change.

@fzaninotto fzaninotto closed this Feb 3, 2024
@fzaninotto fzaninotto deleted the list-setParams branch June 20, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant