[Demo] Remove useless defaultProps usage #9586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React discourages the use of defaultPRops and may one day remove support for it. Our demos contain custom components that don't really need defaultProps, so we replace it with real props. Some custom components with defaultProps remain (StarRatingField, ColoredNumberField, etc) because removing defaultProps for them would lead to a lot of repetition. These currently need defaultProps and there is no better alternative for now.
djhi
requested changes
Jan 16, 2024
| @@ -22,17 +22,4 @@ const ReviewListMobile = () => { | |||
| ); | |||
| }; | |||
|
|
|||
| ReviewListMobile.propTypes = { | |||
There was a problem hiding this comment.
Linter warning in this file.
djhi
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React discourages the use of defaultProps and may one day remove support for it. They aren't even documented in the latest version of the React docs.
Our demos contain custom components that don't really need defaultProps, so this PR replaces it with real props.
Some custom components with defaultProps remain in the demo (StarRatingField, ColoredNumberField, etc) because removing defaultProps for them would lead to a lot of repetition. These currently need defaultProps and there is no better alternative for now.