[Demo] Remove useless defaultProps usage

docs/Fields.md

@@ -288,7 +288,7 @@ And see [the Material UI system documentation](https://mui.com/system/the-sx-pro
 
 This prop defines the text alignment of the field when rendered inside a `<Datagrid>` cell. By default, datagrid values are left-aligned ; for numeric values, it's often better to right-align them. Set `textAlign` to `right` for that.
 
-[`<NumberField>`](./NumberField.md) already uses `textAlign="right"`. Set the default value for this prop if you create a custom numeric field. 
+[`<NumberField>`](./NumberField.md) already uses `textAlign="right"`. Set the default value for this prop if you create a custom numeric field.
 
 ```jsx
 const BasketTotal = () => {

examples/crm/src/deals/DealList.tsx

@@ -44,7 +44,7 @@ const DealList = () => {
 
 const dealFilters = [
     <SearchInput source="q" alwaysOn />,
-    <OnlyMineInput alwaysOn />,
+    <OnlyMineInput source="sales_id" alwaysOn />,
     <SelectInput source="type" choices={typeChoices} />,
 ];
 

examples/crm/src/deals/OnlyMineInput.tsx

@@ -2,7 +2,7 @@ import * as React from 'react';
 import { useListFilterContext, useGetIdentity } from 'react-admin';
 import { Box, Switch, FormControlLabel } from '@mui/material';
 
-export const OnlyMineInput = (_: { alwaysOn: boolean }) => {
+export const OnlyMineInput = (_: { alwaysOn: boolean; source: string }) => {
     const {
         filterValues,
         displayedFilters,
@@ -35,5 +35,3 @@ export const OnlyMineInput = (_: { alwaysOn: boolean }) => {
         </Box>
     );
 };
-
-OnlyMineInput.defaultProps = { source: 'sales_id' };

examples/demo/src/i18n/en.ts

@@ -53,6 +53,7 @@ const customEnglishMessages: TranslationMessages = {
             fields: {
                 commands: 'Orders',
                 first_seen: 'First seen',
+                full_name: 'Name',
                 groups: 'Segments',
                 last_seen: 'Last seen',
                 last_seen_gte: 'Visited Since',

examples/demo/src/i18n/fr.ts

@@ -58,6 +58,7 @@ const customFrenchMessages: TranslationMessages = {
                 commands: 'Commandes',
                 first_name: 'Prénom',
                 first_seen: 'Première visite',
+                full_name: 'Nom',
                 groups: 'Segments',
                 has_newsletter: 'Abonné à la newsletter',
                 has_ordered: 'A commandé',

examples/demo/src/orders/MobileGrid.tsx

@@ -81,9 +81,4 @@ const MobileGrid = () => {
     );
 };
 
-MobileGrid.defaultProps = {
-    data: {},
-    ids: [],
-};
-
 export default MobileGrid;

examples/demo/src/orders/NbItemsField.tsx

@@ -1,14 +1,9 @@
 import * as React from 'react';
-import { FunctionField } from 'react-admin';
+import { FunctionField, FieldProps } from 'react-admin';
 import { Order } from '../types';
 
-const render = (record: Order) => record.basket.length;
-
-const NbItemsField = () => <FunctionField<Order> render={render} />;
-
-NbItemsField.defaultProps = {
-    label: 'resources.commands.fields.nb_items',
-    textAlign: 'right',
-};
+const NbItemsField = (_: FieldProps) => (
+    <FunctionField<Order> render={record => record.basket.length} />
+);
 
 export default NbItemsField;

examples/demo/src/orders/OrderList.tsx

@@ -142,7 +142,10 @@ const TabbedDatagrid = () => {
                             >
                                 <AddressField />
                             </ReferenceField>
-                            <NbItemsField />
+                            <NbItemsField
+                                label="resources.commands.fields.nb_items"
+                                textAlign="right"
+                            />
                             <NumberField
                                 source="total_ex_taxes"
                                 options={{
@@ -190,7 +193,10 @@ const TabbedDatagrid = () => {
                             >
                                 <AddressField />
                             </ReferenceField>
-                            <NbItemsField />
+                            <NbItemsField
+                                label="resources.commands.fields.nb_items"
+                                textAlign="right"
+                            />
                             <NumberField
                                 source="total_ex_taxes"
                                 options={{
@@ -242,7 +248,10 @@ const TabbedDatagrid = () => {
                             >
                                 <AddressField />
                             </ReferenceField>
-                            <NbItemsField />
+                            <NbItemsField
+                                label="resources.commands.fields.nb_items"
+                                textAlign="right"
+                            />
                             <NumberField
                                 source="total_ex_taxes"
                                 options={{

examples/demo/src/products/ProductRefField.tsx

@@ -4,7 +4,7 @@ import { Link as MuiLink } from '@mui/material';
 import { useRecordContext } from 'react-admin';
 import { Product } from '../types';
 
-const ProductRefField = () => {
+const ProductRefField = (_: { source: string }) => {
     const record = useRecordContext<Product>();
     return record ? (
         <MuiLink
@@ -17,9 +17,4 @@ const ProductRefField = () => {
     ) : null;
 };
 
-ProductRefField.defaultProps = {
-    source: 'id',
-    label: 'Reference',
-};
-
 export default ProductRefField;

examples/demo/src/products/ProductReferenceField.tsx

@@ -19,8 +19,4 @@ const ProductReferenceField = (
     </ReferenceField>
 );
 
-ProductReferenceField.defaultProps = {
-    source: 'product_id',
-};
-
 export default ProductReferenceField;

examples/demo/src/reviews/ReviewEdit.tsx

@@ -45,7 +45,7 @@ const ReviewEdit = ({ id, onCancel }: Props) => {
                             </Labeled>
                         </Grid>
                         <Grid item xs={6}>
-                            <Labeled>
+                            <Labeled label="resources.reviews.fields.product_id">
                                 <ProductReferenceField />
                             </Labeled>
                         </Grid>

examples/demo/src/reviews/ReviewListDesktop.tsx

@@ -49,7 +49,7 @@ const ReviewListDesktop = ({ selectedRow }: ReviewListDesktopProps) => (
     >
         <DateField source="date" />
         <CustomerReferenceField link={false} />
-        <ProductReferenceField link={false} />
+        <ProductReferenceField source="product_id" link={false} />
         <StarRatingField size="small" />
         <TextField source="comment" />
         <TextField source="status" />

examples/demo/src/reviews/ReviewListMobile.tsx

@@ -1,5 +1,4 @@
 import * as React from 'react';
-import PropTypes from 'prop-types';
 import { List } from '@mui/material';
 import { RecordContextProvider, useListContext } from 'react-admin';
 
@@ -22,17 +21,4 @@ const ReviewListMobile = () => {
     );
 };
 
-ReviewListMobile.propTypes = {
-    data: PropTypes.any,
-    hasBulkActions: PropTypes.bool.isRequired,
-    ids: PropTypes.array,
-    onToggleItem: PropTypes.func,
-    selectedIds: PropTypes.arrayOf(PropTypes.any).isRequired,
-};
-
-ReviewListMobile.defaultProps = {
-    hasBulkActions: false,
-    selectedIds: [],
-};
-
 export default ReviewListMobile;

examples/demo/src/visitors/CustomerLinkField.tsx

@@ -16,8 +16,4 @@ const CustomerLinkField = (_: FieldProps<Customer>) => {
     );
 };
 
-CustomerLinkField.defaultProps = {
-    source: 'customer_id',
-};
-
 export default CustomerLinkField;

examples/demo/src/visitors/VisitorList.tsx

@@ -51,7 +51,10 @@ const VisitorList = () => {
                         },
                     }}
                 >
-                    <CustomerLinkField />
+                    <CustomerLinkField
+                        source="last_name"
+                        label="resources.customers.fields.full_name"
+                    />
                     <DateField source="last_seen" />
                     <NumberField
                         source="nb_commands"

examples/simple/src/comments/CommentList.tsx

@@ -135,11 +135,6 @@ const CommentGrid = () => {
     );
 };
 
-CommentGrid.defaultProps = {
-    data: {},
-    ids: [],
-};
-
 const CommentMobileList = () => (
     <SimpleList
         primaryText={record => record.author.name}

packages/ra-ui-materialui/src/input/NumberInput.tsx

@@ -172,11 +172,6 @@ NumberInput.propTypes = {
     step: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
 };
 
-NumberInput.defaultProps = {
-    step: 'any',
-    textAlign: 'right',
-};
-
 export interface NumberInputProps
     extends CommonInputProps,
         Omit<