Merge pull request #53 from marp-team/remove-emoji-support

Remove Unicode Emoji support
marp-team · Aug 17, 2018 · d7133ed · d7133ed
2 parents 7ae7b20 + ad4cf3c
commit d7133ed
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 162 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## [Unreleased]
 
+- Remove Unicode Emoji support due to many issues on stable Chrome ([#53](https://github.com/marp-team/marpit/pull/53))
+
 ## v0.0.11 - 2018-08-12
 
 - Bugfix: Pass `class` attribute to pseudo section on advanced background ([#48](https://github.com/marp-team/marpit/pull/48))

diff --git a/package.json b/package.json
@@ -71,7 +71,6 @@
     "rimraf": "^2.6.2"
   },
   "dependencies": {
-    "emoji-regex": "^7.0.0",
     "js-yaml": "^3.12.0",
     "lodash.kebabcase": "^4.1.1",
     "markdown-it": "^8.4.2",

diff --git a/src/markdown/unicode_emoji.js b/src/markdown/unicode_emoji.js
diff --git a/src/marpit.js b/src/marpit.js
@@ -16,7 +16,6 @@ import marpitSlideContainer from './markdown/slide_container'
 import marpitStyleAssign from './markdown/style/assign'
 import marpitStyleParse from './markdown/style/parse'
 import marpitSweep from './markdown/sweep'
-import marpitUnicodeEmoji from './markdown/unicode_emoji'
 
 const defaultOptions = {
   backgroundSyntax: true,
@@ -123,7 +122,6 @@ class Marpit {
       .use(marpitSlideContainer, this.slideContainers)
       .use(marpitContainerPlugin, this.containers)
       .use(marpitParseImage, { filters })
-      .use(marpitUnicodeEmoji)
       .use(marpitSweep)
       .use(marpitInlineSVG, this)
       .use(marpitStyleAssign, this)

diff --git a/src/postcss/printable.js b/src/postcss/printable.js
@@ -39,10 +39,6 @@ const plugin = postcss.plugin('marpit-postcss-printable', opts => css =>
     height: 100vh;
     width: 100vw;
   }
-
-  [data-marpit-emoji] {
-    filter: invert(0);
-  }
 }
 `.trim()
   )

diff --git a/src/theme/scaffold.js b/src/theme/scaffold.js
@@ -1,18 +1,6 @@
 /** @module */
 import Theme from '../theme'
 
-const emojiFonts = [
-  'Apple Color Emoji',
-  'Segoe UI Emoji',
-  'Noto Color Emoji',
-  'Segoe UI Symbol',
-  'Android Emoji',
-  'Twitter Color Emoji',
-  'EmojiOne Color',
-  'Symbola',
-  'EmojiSymbols',
-]
-
 const css = `
 section {
   width: 1280px;
@@ -38,10 +26,6 @@ section:not([data-marpit-pagination])::after {
   display: none;
 }
 
-[data-marpit-emoji] {
-  font-family: ${emojiFonts.map(f => `'${f}'`).join(',')};
-}
-
 /* Normalization */
 h1 {
   font-size: 2em;
@@ -54,7 +38,6 @@ h1 {
  *
  * - Define the default slide size.
  * - Set default style for `<section>`.
- * - Set unicode emoji style for using system emoji fonts.
  * - Normalize `<h1>` heading style.
  *
  * @alias module:theme/scaffold

diff --git a/test/markdown/unicode_emoji.js b/test/markdown/unicode_emoji.js
diff --git a/yarn.lock b/yarn.lock
@@ -1352,10 +1352,6 @@ electron-to-chromium@^1.3.47:
   version "1.3.55"
   resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.55.tgz#f150e10b20b77d9d41afcca312efe0c3b1a7fdce"
 
-emoji-regex@^7.0.0:
-  version "7.0.0"
-  resolved "https://registry.yarnpkg.com/emoji-regex/-/emoji-regex-7.0.0.tgz#7c25d9bb46480f9a5a80ab6a2a12935bdde6cb6c"
-
 entities@^1.1.1, entities@~1.1.1:
   version "1.1.1"
   resolved "https://registry.yarnpkg.com/entities/-/entities-1.1.1.tgz#6e5c2d0a5621b5dadaecef80b90edfb5cd7772f0"