Remove Unicode Emoji support #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chromium has resolved an issue about printing emoji. We are no longer need Marpit's Unicode emoji workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Chrome 68, Marpit's Unicode Emoji support implemented on #18 is not working. This problem was found out in marp-team/marp-core#17.
Problems
Windows
We have resolved an issue of not-colored emoji (Segoe UI Emoji) on exported PDF with Chrome in #18. We applied a bit strange workaround by using filter.
However in reality, it made emoji colorize only that have a font size smaller than 342px, and what is worse, Chrome 68's threshold has decreased to 81.9299965px.
At least emoji will render as monochrome text even if the workaround is not worked.
macOS
There is a more serious problem on macOS Chrome. Apple Color Emoji that has applied workaround will vanish on exported PDF when font size is not smaller than 81.9299965px. The current macOS Chrome is rendering colored Emoji on PDF correctly, so the workaround for Windows Segoe UI Emoji will make the problem worse.
Decision
We will remove workarounds to make Unicode Emoji be printable. A minimum requirement to render emoji on PDF has fullfilled even if we do nothing.
We can still track a Chromium issue about not-colored Emoji at https://bugs.chromium.org/p/chromium/issues/detail?id=617379.