Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Windows display language instead of regional format #2285

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Use Windows display language instead of regional format #2285

merged 2 commits into from
Jun 5, 2024

Conversation

KimCM
Copy link
Contributor

@KimCM KimCM commented Jun 5, 2024

Translate UI content based on CurrentUICulture instead of CurrentCulture.

CurrentCulture is the .NET representation of the default user locale of the system. This controls default number and date formatting and the like.

CurrentUICulture refers to the default user interface language, a setting introduced in Windows 2000. This is primarily regarding the UI localization/translation part of your app.

further information

Closes #2141
Closes #1783

  • I have read the contributing guidelines and I agree with the Code of Conduct
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.

KimCM added 2 commits June 5, 2024 07:32
Translate UI content based on CurrentUICulture instead of CurrentCulture.

CurrentCulture is the .NET representation of the default user locale of the system. This controls default number and date formatting and the like.

CurrentUICulture refers to the default user interface language, a setting introduced in Windows 2000. This is primarily regarding the UI localization/translation part of your app.

see also
* https://stackoverflow.com/questions/329033/what-is-the-difference-between-currentculture-and-currentuiculture-properties-of
* https://learn.microsoft.com/en-us/dotnet/api/system.globalization.cultureinfo.currentuiculture?view=net-8.0
* https://learn.microsoft.com/en-us/dotnet/fundamentals/runtime-libraries/system-globalization-cultureinfo-currentuiculture

fix #2141
@marticliment marticliment merged commit d3521fe into marticliment:main Jun 5, 2024
1 of 2 checks passed
@KimCM KimCM deleted the bug-2141 branch June 5, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants