Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the rest of the low-hanging-fruit built-ins #132

Merged
merged 65 commits into from
May 18, 2020

Conversation

masak
Copy link
Owner

@masak masak commented May 4, 2020

This work builds on #117; please rebase on top of master after that one merges. Thanks Rebased.

This PR implements drop, first, whenlet, awhen, each, flip, part, trap, only, >=, <=, floor, ceil, mod, whilet, loop, while, til, for, repeat, poll, accum, nof, drain, ^w, clog2, coin, randlen, rand, wipe, clean, swap, adjoin, pushnew, dedup, insert, sort, best, max, min, even, odd, round, array, vir arr, aref, table, vir tab, tabref, loc isa!tab, tabrem, templates, tem, make, inst. Yep, that's most of the rest.

Notably, a few things were skipped in this PR and will be tackled later:

The test suite took its biggest speed hit so far in the project by the work in this PR. The test suite (running under prove with -j4) went from 131 s to 836 s. Similar slowdowns happened with #73 and #96, both of which also added global definitions. Likely, working on speeding up numbers (#91 and #140) would give the biggest payoff after this. (Later edit: Nope, turns out it was #194; faster numbers will probably help too, though.)

Closes #126.
Closes #127.
Closes #129.

@masak masak changed the title Implement another set of low-hanging fruit built-ins Implement another set of low-hanging-fruit built-ins May 4, 2020
@masak masak force-pushed the masak/ever-more-builtins branch 3 times, most recently from 5366b6c to 164b127 Compare May 10, 2020 13:47
@masak masak force-pushed the masak/ever-more-builtins branch 3 times, most recently from 925a581 to fe30e2f Compare May 17, 2020 08:54
@masak masak marked this pull request as ready for review May 17, 2020 12:04
@masak masak force-pushed the masak/ever-more-builtins branch from fe30e2f to 29b3836 Compare May 17, 2020 12:36
@masak masak force-pushed the masak/ever-more-builtins branch from 29b3836 to 3b06276 Compare May 17, 2020 13:53
@masak masak changed the title Implement another set of low-hanging-fruit built-ins Implement the rest of the low-hanging-fruit built-ins May 18, 2020
@masak masak merged commit 74e14c1 into master May 18, 2020
@masak masak deleted the masak/ever-more-builtins branch May 18, 2020 13:43
This was referenced May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement templates Implement tables Implement arrays
1 participant