-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the rest of the low-hanging-fruit built-ins #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masak
changed the title
Implement another set of low-hanging fruit built-ins
Implement another set of low-hanging-fruit built-ins
May 4, 2020
masak
force-pushed
the
masak/ever-more-builtins
branch
3 times, most recently
from
May 10, 2020 13:47
5366b6c
to
164b127
Compare
masak
force-pushed
the
masak/ever-more-builtins
branch
3 times, most recently
from
May 17, 2020 08:54
925a581
to
fe30e2f
Compare
Unexpected successes were mistakenly reported as "ok" iff their output was _wrong_. Oops.
masak
force-pushed
the
masak/ever-more-builtins
branch
from
May 17, 2020 12:36
fe30e2f
to
29b3836
Compare
masak
force-pushed
the
masak/ever-more-builtins
branch
from
May 17, 2020 13:53
29b3836
to
3b06276
Compare
masak
changed the title
Implement another set of low-hanging-fruit built-ins
Implement the rest of the low-hanging-fruit built-ins
May 18, 2020
This was referenced May 18, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work builds on #117; please rebase on top ofRebased.master
after that one merges. ThanksThis PR implements
drop
,first
,whenlet
,awhen
,each
,flip
,part
,trap
,only
,>=
,<=
,floor
,ceil
,mod
,whilet
,loop
,while
,til
,for
,repeat
,poll
,accum
,nof
,drain
,^w
,clog2
,coin
,randlen
,rand
,wipe
,clean
,swap
,adjoin
,pushnew
,dedup
,insert
,sort
,best
,max
,min
,even
,odd
,round
,array
,vir arr
,aref
,table
,vir tab
,tabref
,loc isa!tab
,tabrem
,templates
,tem
,make
,inst
. Yep, that's most of the rest.Notably, a few things were skipped in this PR and will be tackled later:
chars
(Implement the 'chars' builtin #120) — so, waiting withnchar
(wait, do we really have to wait? we can mockchars
, can't we?)err
andccc
(Allow dynamic overriding oferr
#79 and Implementccc
form #80) — so we skipcatch
for nowNo, we do support them now (the backquotes were not all that nested), and soswap
(Implementswap
#87) because it uses nested bquotes which we don't currently supportswap
is here too!withfile
,from
,to
,readall
,load
andpr
The test suite took its biggest speed hit so far in the project by the work in this PR. The test suite (running under
prove
with-j4
) went from 131 s to 836 s. Similar slowdowns happened with #73 and #96, both of which also added global definitions. Likely, working on speeding up numbers (#91 and #140) would give the biggest payoff after this. (Later edit: Nope, turns out it was #194; faster numbers will probably help too, though.)Closes #126.
Closes #127.
Closes #129.