Use hash lookup to find global values #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2020
added 12 commits
July 11, 2020 23:03
As a first step towards creating a global object that can do hash-based lookups.
This is a precursor to building the linked list at the same time as the hash. Doing things in small refactor steps is very nice, besides being almost essential.
This slows down the test suite considerably; I think because the order the globals are accessed is now predictable, and (maybe more importantly) many of the commonly-called globals end up fairly deep in the list. Of course, with some searching we could find a better order for the globals, to make the test suite run faster. But by the end of this branch, it won't matter either way, because we'll be doing hash-based lookups.
This is a precursor to just accessing the pairs directly by hash.
We'll probably go back to storing a "globals object" quite soon, because the globals shouldn't be a singleton like they are now. But as long as they are, this is the simpler form.
masak
force-pushed
the
masak/fastify-globals
branch
from
0035277 to
b208ce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the test suite by about 70%.