Modify datastore_manipulation test to add prefix to getKeys and getKeysOf #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sydhds Could you review this PR so I can merge it and create the release, it is currently blocking the merge of massalabs/massa#3640 |
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
litchipi
force-pushed
the
tim/get_keys_prefix
branch
from
b29ed59 to
f6fca2f
Compare
sydhds
requested changes
Mar 29, 2023
| @@ -7,28 +7,44 @@ | |||
| * which is ready to be send on Massa network node! | |||
| **/ | |||
|
|
|||
| import { Storage, getKeys, getKeysOf, generateEvent, Context, print } from "@massalabs/massa-as-sdk"; | |||
| import {Storage, getKeys, getKeysOf, generateEvent, Context, print} from "@massalabs/massa-as-sdk"; | |||
|
|
|||
| export function main(_args: string): void { | |||
There was a problem hiding this comment.
I would recommend writing a second test and keep this one as simple as possible :)
There was a problem hiding this comment.
Separated the test in two halfs with a comment in between, tell me if that's OK for you
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
sydhds
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the implementation of massalabs/massa-as-sdk#163
Create tests for massalabs/massa#3640