Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new ABI "get_matching_keys_for" #3640

Merged
merged 18 commits into from
Mar 31, 2023
Merged

Implement new ABI "get_matching_keys_for" #3640

merged 18 commits into from
Mar 31, 2023

Conversation

litchipi
Copy link
Contributor

@litchipi litchipi commented Mar 3, 2023 •
edited
Loading

Closes: #3625
PR in the massa-sc-runtime repo: massalabs/massa-sc-runtime#237

New ABI to get all the keys in a datastore matching a given prefix

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@litchipi litchipi changed the base branch from main to testnet_21 March 3, 2023 17:34
@AurelienFT AurelienFT marked this pull request as draft March 3, 2023 20:16
@litchipi
Edit get_keys() and get_keys_for() ABI, adding a prefix filter
eb3003d 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi litchipi force-pushed the abi_get_matching_keys_for branch from ef3a868 to eb3003d Compare March 6, 2023 14:29
litchipi added 4 commits March 6, 2023 15:59
@litchipi
lint
27215e4 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Update massa-sc-runtime to latest
e7fad6d 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Fixing problems on the code
bb007f2 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Fix clippy warn
3a97df4 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi litchipi marked this pull request as ready for review March 7, 2023 09:07
@litchipi litchipi mentioned this pull request Mar 9, 2023
Merged
litchipi added 4 commits March 9, 2023 17:00
@litchipi
Update unit tests for datastore manipulations
35dfbcc 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Make keys unit testing pass
4f369f4 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Test failling for amount left on ledger
4fb715f 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Fixing ledger costs in unit test
0da6e6e 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi litchipi requested a review from sydhds March 10, 2023 09:17
litchipi added 7 commits March 10, 2023 10:19
@litchipi
format code
38ddd48 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Update unit tests release tag to TEST.20.3
9a59dff 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Update massa-sc-runtime to latest
5ddf6ff 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Fixup unit test to new WASM file
4a33ca6 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Merge branch 'testnet_21' into abi_get_matching_keys_for
eed31d2
@litchipi
Update WASM tests for new release TEST.20.3
dae4ba9 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
lint code
10cb7ae 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi litchipi mentioned this pull request Mar 30, 2023
Merged
7 tasks
@litchipi
Copy link
Contributor Author

@sydhds Ready for review before merge 😃

@AurelienFT AurelienFT requested review from AurelienFT and removed request for sydhds March 31, 2023 10:18
litchipi and others added 2 commits March 31, 2023 16:15
@litchipi @AurelienFT
Update massa-execution-worker/src/interface_impl.rs
1f11675 
Co-authored-by: AurelienFT <32803821+AurelienFT@users.noreply.github.com>
@litchipi
apply suggestion & lint
8731e21 
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
AurelienFT
AurelienFT approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

@litchipi litchipi merged commit 1e41cd1 into testnet_21 Mar 31, 2023
@AurelienFT AurelienFT mentioned this pull request Apr 3, 2023
Closed
@AurelienFT AurelienFT deleted the abi_get_matching_keys_for branch May 29, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@litchipi @AurelienFT