Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test a scenario in execution #2079

Closed
AureliaDolo opened this issue Jan 5, 2022 · 2 comments · Fixed by #2296
Closed

test a scenario in execution #2079

AureliaDolo opened this issue Jan 5, 2022 · 2 comments · Fixed by #2296
Assignees
Labels
need spec This issue need more specification smart-contracts Issue related to the smart contract world tests Issues related to testing the node
Milestone

Comments

@AureliaDolo
Copy link
Contributor

No description provided.

@AureliaDolo AureliaDolo added smart-contracts Issue related to the smart contract world tests Issues related to testing the node labels Jan 5, 2022
@AureliaDolo
Copy link
Contributor Author

@damip I would happily take suggestions on this one

And I'm not sure I see where we have anyway of seeing if everything is ok in the execution component

@damip
Copy link
Member

damip commented Jan 6, 2022

for most execution tests to be possible, we first need to implement SCE ledger readout functions (also useful for the API/client)

@AureliaDolo AureliaDolo added this to the TEST.7.0 milestone Jan 10, 2022
@damip damip moved this to Todo - for that week in Smart Contracts Jan 17, 2022
@yvan-sraka yvan-sraka modified the milestones: TEST.7.0, TEST.8.0 Feb 8, 2022
@AureliaDolo AureliaDolo added the need spec This issue need more specification label Feb 10, 2022
@adrien-zinger adrien-zinger linked a pull request Feb 15, 2022 that will close this issue
bors bot added a commit that referenced this issue Feb 23, 2022
2296: Add tests for massa execution r=adrien-zinger a=adrien-zinger

Add tests for the execution module & fix events.

Related with the issue #2079, we want to add test in the execution module. I suggest to not duplicate all tests, but test the layer of the massa usage. For example, we add the events and the current PR test if the implementation is good.

Add a unit test for the event generation, build a local wasm project on massa-execution build. Then execute the test.
    
Fixes: the events were not stored correctly in `final_events`
Changes: Filter slot, include last slot.


_this PR was a draft because we need to merge #2290 before_


Co-authored-by: Adrien Zinger <zinger.ad@gmail.com>
@damip damip modified the milestones: TEST.8.0, TEST.9.0 Mar 3, 2022
bors bot added a commit that referenced this issue Mar 22, 2022
2296: Add tests for massa execution r=yvan-sraka a=adrien-zinger

Add tests for the execution module & fix events.

Related with the issue #2079, we want to add test in the execution module. I suggest to not duplicate all tests, but test the layer of the massa usage. For example, we add the events and the current PR test if the implementation is good.

Add a unit test for the event generation, build a local wasm project on massa-execution build. Then execute the test.
    
Fixes: the events were not stored correctly in `final_events`
Changes: Filter slot, include last slot.


_this PR was a draft because we need to merge #2290 before_


Co-authored-by: Adrien Zinger <zinger.ad@gmail.com>
@bors bors bot closed this as completed in #2296 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need spec This issue need more specification smart-contracts Issue related to the smart contract world tests Issues related to testing the node
Projects
No open projects
Status: Todo - for that week
Development

Successfully merging a pull request may close this issue.

4 participants