Add tests for massa execution #2296

adrien-zinger · 2022-02-15T15:57:57Z

Add tests for the execution module & fix events.

Related with the issue #2079, we want to add test in the execution module. I suggest to not duplicate all tests, but test the layer of the massa usage. For example, we add the events and the current PR test if the implementation is good.

Add a unit test for the event generation, build a local wasm project on massa-execution build. Then execute the test.

Fixes: the events were not stored correctly in final_events
Changes: Filter slot, include last slot.

this PR was a draft because we need to merge #2290 before

yvan-sraka

LGTM, event if I would prefer to import wasm_tests as a git submodule or an external dependency rather than adding it to this repo ...

adrien-zinger · 2022-02-23T14:58:20Z

bors merge

2296: Add tests for massa execution r=adrien-zinger a=adrien-zinger Add tests for the execution module & fix events. Related with the issue #2079, we want to add test in the execution module. I suggest to not duplicate all tests, but test the layer of the massa usage. For example, we add the events and the current PR test if the implementation is good. Add a unit test for the event generation, build a local wasm project on massa-execution build. Then execute the test. Fixes: the events were not stored correctly in `final_events` Changes: Filter slot, include last slot. _this PR was a draft because we need to merge #2290 before_ Co-authored-by: Adrien Zinger <zinger.ad@gmail.com>

bors · 2022-02-23T15:03:47Z

Build failed:

build

damip

Warning; this adds a major dependency for the whole build system (yarn + all the JS/AS libs), even when not building tests but just compiling the program !

Would it be possible to put that behind a feature that disables this dependency and the tests that depend on it when it's off ? And to make sure that just building the node doesn't require a yarn setup ?

damip

I still see the problem I mentionned in my previous review

2249: Speculative execution support r=damip a=damip # Intro This is a rewrite of the execution system following the spec we already agreed upon, as well as good practices and with the big refactoring constraints in mind. # Goals * [x] enable speculative execution * [x] get ready for ledger unification # Practices * [x] no async because it's not needed * [x] short functions (max 50 lines of code) * [x] no panics, unless described * crates split between worker and exports * [x] execution * [x] ledger: it will be refactored for on-disk storage, we will split it then => #2342 * thorough documentation * [x] function docs * [x] algorithm description * [x] file-level documentation * [x] crate-level documentation * [x] test exports * [x] unit and functional tests: to be added in a followup #2296 * [x] use genericity whenever possible * [x] clippy lints # Checklist * [x] implement speculative execution * [x] split execution into worker/exports crates * [x] create massa-ledger crate * [x] integrate execution and ledger into the existing program * [x] repair bootstrap tests * [x] repair consensus tests * [x] improve documentation * [x] try on labnet * [x] reactivate execution tests => will be done in a followup #2296 * [x] add specific tests => will be done in the followup #2296 Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: damip <damipator@gmail.com>

damip · 2022-03-01T07:45:06Z

When #2249 is merged, we can adapt this one

2249: Speculative execution support r=damip a=damip # Intro This is a rewrite of the execution system following the spec we already agreed upon, as well as good practices and with the big refactoring constraints in mind. # Goals * [x] enable speculative execution * [x] get ready for ledger unification # Practices * [x] no async because it's not needed * [x] short functions (max 50 lines of code) * [x] no panics, unless described * crates split between worker and exports * [x] execution * [x] ledger: it will be refactored for on-disk storage, we will split it then => #2342 * thorough documentation * [x] function docs * [x] algorithm description * [x] file-level documentation * [x] crate-level documentation * [x] test exports * [x] unit and functional tests: to be added in a followup #2296 * [x] use genericity whenever possible * [x] clippy lints # Checklist * [x] implement speculative execution * [x] split execution into worker/exports crates * [x] create massa-ledger crate * [x] integrate execution and ledger into the existing program * [x] repair bootstrap tests * [x] repair consensus tests * [x] improve documentation * [x] try on labnet * [x] reactivate execution tests => will be done in a followup #2296 * [x] add specific tests => will be done in the followup #2296 Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: damip <damipator@gmail.com>

adrien-zinger · 2022-03-03T07:56:40Z

bors try

bors · 2022-03-03T07:57:25Z

try

Build failed:

build

massa-execution-exports/src/event_store.rs

massa-execution-exports/src/test_exports/settings.rs

massa-execution-worker/src/tests/scenarios_mandatories.rs

massa-models/src/node_configuration/default_testing.rs

massa-execution-exports/src/event_store.rs

massa-execution-worker/src/tests/scenarios_mandatories.rs

massa-execution-worker/src/worker.rs

massa-models/src/node_configuration/default_testing.rs

yvan-sraka

LGTM (nice improvements happen here)! With few comments 👍

massa-execution-exports/src/test_exports/settings.rs

massa-hash/src/error.rs

massa-ledger/src/test_exports/config.rs

massa-models/src/node_configuration/default_testing.rs

Co-authored-by: Aurelia <56112063+AureliaDolo@users.noreply.github.com>

damip · 2022-03-22T11:38:53Z

Let's reboot this :)

Prioritary review !

yvan-sraka · 2022-03-22T11:39:08Z

bors merge

damip · 2022-03-22T11:39:47Z

thanks @yvan-sraka that was fast !

bors · 2022-03-22T12:41:01Z

Build succeeded:

build

adrien-zinger requested review from yvan-sraka and AureliaDolo February 15, 2022 15:57

adrien-zinger self-assigned this Feb 15, 2022

adrien-zinger linked an issue Feb 15, 2022 that may be closed by this pull request

test a scenario in execution #2079

Closed

adrien-zinger marked this pull request as draft February 15, 2022 15:58

adrien-zinger force-pushed the feature/add_tests_for_massa_execution branch from 177b8f7 to 1c09292 Compare February 15, 2022 16:21

adrien-zinger changed the title ~~Feature/add tests for massa execution~~ Add tests for massa execution Feb 16, 2022

adrien-zinger force-pushed the feature/add_tests_for_massa_execution branch from 1c09292 to 3a1afe2 Compare February 23, 2022 09:05

adrien-zinger mentioned this pull request Feb 23, 2022

Add docs and fix latest warnings #2290

Closed

adrien-zinger marked this pull request as ready for review February 23, 2022 09:08

yvan-sraka previously approved these changes Feb 23, 2022

View reviewed changes

damip self-requested a review February 23, 2022 09:23

AureliaDolo mentioned this pull request Feb 23, 2022

Next release checklist (8.0 or 7.1) #2273

Closed

16 tasks

AureliaDolo previously approved these changes Feb 23, 2022

View reviewed changes

adrien-zinger dismissed stale reviews from AureliaDolo and yvan-sraka via 18873b7 February 23, 2022 15:50

AureliaDolo previously approved these changes Feb 23, 2022

View reviewed changes

damip mentioned this pull request Feb 23, 2022

Speculative execution support #2249

Merged

25 tasks

damip requested changes Feb 23, 2022

View reviewed changes

yvan-sraka requested review from damip and yvan-sraka February 24, 2022 12:57

damip requested changes Feb 26, 2022

View reviewed changes

adrien-zinger dismissed AureliaDolo’s stale review via c37a5ee March 2, 2022 16:10

adrien-zinger force-pushed the feature/add_tests_for_massa_execution branch from 18873b7 to c37a5ee Compare March 2, 2022 16:10

adrien-zinger requested review from damip and AureliaDolo March 3, 2022 07:34

Add some execution tests

cf2e1a5

adrien-zinger force-pushed the feature/add_tests_for_massa_execution branch from c37a5ee to cf2e1a5 Compare March 3, 2022 07:42

bors bot added a commit that referenced this pull request Mar 3, 2022

Try #2296:

847c1fe

AureliaDolo reviewed Mar 3, 2022

View reviewed changes

AureliaDolo reviewed Mar 8, 2022

View reviewed changes

AureliaDolo added the review requested label Mar 9, 2022

yvan-sraka previously approved these changes Mar 9, 2022

View reviewed changes

massa-execution-exports/src/test_exports/settings.rs Show resolved Hide resolved

massa-hash/src/error.rs Show resolved Hide resolved

massa-ledger/src/test_exports/config.rs Show resolved Hide resolved

massa-models/src/node_configuration/default_testing.rs Show resolved Hide resolved

adrien-zinger dismissed yvan-sraka’s stale review via 5e1183a March 11, 2022 15:26

adrien-zinger and others added 2 commits March 22, 2022 11:12

Merge main into feature tests

ee6eab7

remove useless compilation tag

a9eaf83

Co-authored-by: Aurelia <56112063+AureliaDolo@users.noreply.github.com>

adrien-zinger force-pushed the feature/add_tests_for_massa_execution branch from 5e1183a to a9eaf83 Compare March 22, 2022 10:16

damip requested review from AureliaDolo and yvan-sraka March 22, 2022 11:38

damip approved these changes Mar 22, 2022

View reviewed changes

yvan-sraka approved these changes Mar 22, 2022

View reviewed changes

damip removed the review requested label Mar 22, 2022

bors bot merged commit af2ecd0 into main Mar 22, 2022

bors bot deleted the feature/add_tests_for_massa_execution branch March 22, 2022 12:41

SecorD0 pushed a commit to SecorD0/massa-fixing that referenced this pull request Dec 2, 2022

Try massalabs#2296:

4f30bae

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for massa execution #2296

Add tests for massa execution #2296

adrien-zinger commented Feb 15, 2022 •

edited

Loading

yvan-sraka left a comment

adrien-zinger commented Feb 23, 2022

bors bot commented Feb 23, 2022

damip left a comment •

edited

Loading

damip left a comment

damip commented Mar 1, 2022

adrien-zinger commented Mar 3, 2022

bors bot commented Mar 3, 2022

yvan-sraka left a comment

damip commented Mar 22, 2022

yvan-sraka commented Mar 22, 2022

damip commented Mar 22, 2022 •

edited

Loading

bors bot commented Mar 22, 2022

Add tests for massa execution #2296

Add tests for massa execution #2296

Conversation

adrien-zinger commented Feb 15, 2022 • edited Loading

yvan-sraka left a comment

Choose a reason for hiding this comment

adrien-zinger commented Feb 23, 2022

bors bot commented Feb 23, 2022

damip left a comment • edited Loading

Choose a reason for hiding this comment

damip left a comment

Choose a reason for hiding this comment

damip commented Mar 1, 2022

adrien-zinger commented Mar 3, 2022

bors bot commented Mar 3, 2022

try

yvan-sraka left a comment

Choose a reason for hiding this comment

damip commented Mar 22, 2022

yvan-sraka commented Mar 22, 2022

damip commented Mar 22, 2022 • edited Loading

bors bot commented Mar 22, 2022

adrien-zinger commented Feb 15, 2022 •

edited

Loading

damip left a comment •

edited

Loading

damip commented Mar 22, 2022 •

edited

Loading