Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ node_ban_by_id ] doesn't work #3632

Closed
J-P1 opened this issue Mar 2, 2023 · 6 comments · Fixed by #3823
Closed

[ node_ban_by_id ] doesn't work #3632

J-P1 opened this issue Mar 2, 2023 · 6 comments · Fixed by #3823
Assignees

Comments

@J-P1
Copy link

J-P1 commented Mar 2, 2023

Après exécution de la commande, nous avons le retour comme quoi tout s'est bien passé mais il n'y a pas de BAN.

N128bHymXiZFig5fT974ga9ooKFFzecTnAbDsk5Kg77TtzNMvBBn Request of banning successfully sent!

get_status
Banned peers : 0

il se reconnecte et déconnecte encore...

@modship modship self-assigned this Mar 2, 2023
@modship
Copy link
Member

modship commented Mar 2, 2023

Hello,

Can you confirm that when you use the command node_ban_by_id NODE_ID the remote peer is connected to your node ?

The ip of the remote node_id is retrieved from the active connections of your node.

Maybe we should print an error when you call node_ban_by_id and the remote peer isn't actually connected.

@J-P1
Copy link
Author

J-P1 commented Mar 2, 2023

Bonjour,
vous avez certainement raison, quand j'ai utiliser la commande le node devait pas être connecté puisque là je viens de faire un test et ça a fonctionné.

Peut-être afficher une erreur quand le node n'est pas connectée, c'est une très bonne idée ça évitera les questions et les demandes inutiles.
Merci pour votre réactivité

@J-P1
Copy link
Author

J-P1 commented Mar 2, 2023

Par contre la fonction node_ban_by_ip fonctionne parfaitement, même si le node n'arrive pas à se connecter et provoquant déconnexion et reconnexion tout le temps, je vais utiliser cette commande.

@qdrn qdrn changed the title [ node_ban_by_id ] Ne fonctionne pas. [ node_ban_by_id ] doesn't work Mar 9, 2023
@AurelienFT
Copy link
Contributor

@modship I don't remember the state of this did we fix ?

@modship
Copy link
Member

modship commented Apr 3, 2023

@AurelienFT no,

think we should add a log : #3632 (comment) ?

@AurelienFT
Copy link
Contributor

Yes maybe a log could be enough

@modship modship linked a pull request Apr 13, 2023 that will close this issue
7 tasks
@modship modship closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants