Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log for node_ban_by_ids #3823

Merged
merged 1 commit into from
Apr 13, 2023
Merged

add log for node_ban_by_ids #3823

merged 1 commit into from
Apr 13, 2023

Conversation

modship
Copy link
Member

@modship modship commented Apr 13, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

close #3632

@modship modship linked an issue Apr 13, 2023 that may be closed by this pull request
@modship modship requested a review from AurelienFT April 13, 2023 08:51
@modship modship merged commit 0304815 into testnet_22 Apr 13, 2023
Ben-PH pushed a commit that referenced this pull request Apr 17, 2023
@AurelienFT AurelienFT deleted the log_node_ban_ids branch October 23, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ node_ban_by_id ] doesn't work
2 participants