-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intial bip34 like for versioning #3578
Closed
Leo-Besancon
wants to merge
42
commits into
test/versioning_test_transition_fsm_1
from
intial_bip34_like_for_versioning
Closed
Intial bip34 like for versioning #3578
Leo-Besancon
wants to merge
42
commits into
test/versioning_test_transition_fsm_1
from
intial_bip34_like_for_versioning
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Leo-Besancon
commented
Feb 16, 2023
- document all added functions
- try in sandbox /simulation/labnet
- unit tests on the added/changed features
- make tests compile
- make tests pass
- add logs allowing easy debugging in case the changes caused problems
- if the API has changed, update the API specification
Some notes:
|
…cleaning + comms with other modules
Leo-Besancon
force-pushed
the
intial_bip34_like_for_versioning
branch
from
February 22, 2023 11:30
986d0c6
to
daf367d
Compare
Leo-Besancon
changed the base branch from
testnet_20
to
test/versioning_test_transition_fsm_1
February 22, 2023 11:31
…4_like_for_versioning
…/massalabs/massa into intial_bip34_like_for_versioning
sydhds
force-pushed
the
test/versioning_test_transition_fsm_1
branch
from
February 24, 2023 09:20
1615a9f
to
152f1ed
Compare
This PR is outdated, the follow-up is at #3664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.