Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Versioning middleware #3664

Closed
wants to merge 17 commits into from
Closed

Added Versioning middleware #3664

wants to merge 17 commits into from

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Mar 9, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

This was referenced Mar 13, 2023
Closed
Closed
sydhds
sydhds requested changes Mar 20, 2023
View reviewed changes
massa-models/src/config/constants.rs Outdated Show resolved Hide resolved
massa-node/src/main.rs Outdated Show resolved Hide resolved
massa-versioning-exports/src/error.rs Outdated Show resolved Hide resolved
massa-versioning-worker/src/versioning.rs Show resolved Hide resolved
massa-versioning-worker/src/versioning.rs Outdated Show resolved Hide resolved
massa-versioning-worker/src/versioning_middleware.rs Outdated Show resolved Hide resolved
massa-versioning-worker/src/versioning_middleware.rs Outdated Show resolved Hide resolved
massa-versioning-worker/src/versioning_middleware.rs Outdated Show resolved Hide resolved
massa-versioning-worker/src/versioning_middleware.rs Outdated Show resolved Hide resolved
massa-versioning-worker/src/versioning_middleware.rs Outdated Show resolved Hide resolved
@Leo-Besancon Leo-Besancon force-pushed the feature/block_stats_for_versioning branch from 8217af4 to 1a7430d Compare March 20, 2023 13:07
sydhds
sydhds requested changes Mar 20, 2023
View reviewed changes
massa-versioning-worker/src/lib.rs Show resolved Hide resolved
massa-versioning-worker/src/versioning.rs Outdated Show resolved Hide resolved
massa-versioning-worker/src/versioning.rs Outdated Show resolved Hide resolved
Leo-Besancon and others added 14 commits March 27, 2023 15:33
@Leo-Besancon Leo-Besancon force-pushed the feature/block_stats_for_versioning branch from 6ad687a to cab71fe Compare March 27, 2023 13:51
sydhds
sydhds requested changes Mar 27, 2023
View reviewed changes
massa-versioning-worker/Cargo.toml Outdated Show resolved Hide resolved
@Leo-Besancon
Copy link
Collaborator Author

@sydhds added the changes in this PR (among others) in #3744 and #3736
We can close this one now.

@Leo-Besancon Leo-Besancon deleted the feature/block_stats_for_versioning branch April 6, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydhds sydhds sydhds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leo-Besancon @sydhds