Network restart followup #3783

Leo-Besancon · 2023-04-06T13:31:40Z

document all added functions
try in sandbox /simulation/labnet
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

Tested in labnet:

Basic network behaviour (send_tx, buy/sell rolls, etc.)
Restart the network and keep roll information
Bootstrap on initial network and after network restart
Send 1500 txps

… ones

This does not build, I have to add the logic of apply_change to the given ledger_batch

- Created massa-db package for easier access to rocks_db in final_state - Put the AsyncPool in rocks_db - Re-designed the speculative async_pool to avoid querying rocks_db too much /!\ Tests fail! Need to investigate But now the execution tests are not in a deadlock state.

Iteration per message > Iteration per key

…atch

Co-authored-by: Litchi Pi (Tim) <litchi.pi@proton.me>

* Add mip_store in final_state * Add reset_db in MIP store * Fix bootstrap test - added the case of empty Versioning bootstrap We have to rethink of how the cursors work, see follow up issue #4000 * Rework shutdown start & shutdown end computation for final state check * Rework delete_prefix * Rework extend_from_db for MipStore --------- Co-authored-by: sydhds <sd@massa.net> Co-authored-by: Leo-Besancon <leoleo38@live.fr>

Eitu33 · 2023-06-01T07:54:52Z

Congrats 🥳

AurelienFT · 2023-06-01T08:03:23Z

Yeahhhhh !

modship · 2023-06-01T08:16:16Z

👏🏻

Optim: If we need to interpolate a lot of cycles, only build the last…

eee6768

… ones

Leo-Besancon linked an issue Apr 6, 2023 that may be closed by this pull request

Be able to restart the network #3611

Closed

TEST RocksDB checkpoints

46682b9

AurelienFT changed the base branch from testnet_21 to testnet_22 April 7, 2023 09:49

Added logs for ledger backups and recovery (check hash)

b19ea9d

Leo-Besancon self-assigned this Apr 7, 2023

Leo-Besancon and others added 23 commits April 12, 2023 10:34

Moved the LedgerBatch to final_state, step 1

67aa38c

This does not build, I have to add the logic of apply_change to the given ledger_batch

Pass around a handle to the RocksDB DB instead of creating multiple ones

da8324a

Resolve deadlock in bootstrap test

b1d1224

Changed AyncPool methods, bootstrap fails

d83a6cd

Fixed bug in bootstrap test.

7d591f2

Resolved serializing issue with AsyncMessage in DB

f7de52e

fixed doc test

248b9a7

Added mini cache to async_pool, and used SetUpdateOrDelete

c9872a6

Update mini cache + doctest passes

3e9b574

Merge branch 'testnet_22' into network_restart_followup

c5c3f28

Fix after merge

12339f6

Boilerplate for new rocks_db in final_state

0f12016

RocksDB for executed_ops and denunciations

975b6c2

Fmt + Clippy fix

49b3df8

Updated Pool message iterating

e782ff4

Merge branch 'testnet_22' into network_restart_followup

931a53a

Handle the async_pool iteration differently

b1527fb

Iteration per message > Iteration per key

Merge branch 'testnet_22' into network_restart_followup

5ebb93e

Fixed after merge

6a10630

Cleaned some things + docs

416e8bc

Recompute all caches on init of final_state

cfe500e

Additionnal cleaning (e.g. unused function)

76c1b74

Leo-Besancon marked this pull request as ready for review May 2, 2023 12:25

Leo-Besancon and others added 9 commits May 29, 2023 19:49

Use format!() to construct backup directory

2d3d174

Clean batch allocation in massa_db

13ac6ce

Used assert_eq!() instead of panic!() in finalize

4836e6a

Use unreachable!() instead of todo!() in massa-hash

4610107

Added debug_assert_eq!() to check Hash size and LsmTree output_size m…

4b3d153

…atch

Commit review suggestion

cc185d9

Co-authored-by: Litchi Pi (Tim) <litchi.pi@proton.me>

Cargo fmt fix

51f9841

Updated state_step inconsistant error messages

95e5599

Updated XOR hash comment

1d02426

Leo-Besancon requested a review from sydhds May 30, 2023 07:23

Leo-Besancon requested a review from litchipi May 30, 2023 16:11

Leo-Besancon and others added 5 commits May 30, 2023 18:27

Merge branch 'testnet_23' into network_restart_followup

f1ca5cf

Fix after merge

6402b40

Merge branch 'testnet_23' into network_restart_followup

5d7a241

Fix after merge

11470b2

Improve error message if update_batches call fail

f2a1923

modship linked an issue May 31, 2023 that may be closed by this pull request

Ensure that all the determinism-sensitive crates have fixed versions #3899

Closed

modship mentioned this pull request May 31, 2023

Ensure that all the determinism-sensitive crates have fixed versions #3899

Closed

Leo-Besancon and others added 4 commits May 31, 2023 11:29

Merge branch 'testnet_23' into network_restart_followup

9bb3e25

Fix lsmtree version in massa_db

86d5b92

Update MAX_BOOTSTRAPPED_NEW_ELEMENTS to 500

cf3f795

Merge branch 'testnet_23' into network_restart_followup

85ac91c

sydhds approved these changes Jun 1, 2023

View reviewed changes

litchipi approved these changes Jun 1, 2023

View reviewed changes

Leo-Besancon merged commit 2e4efb0 into testnet_23 Jun 1, 2023

sydhds deleted the network_restart_followup branch June 1, 2023 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network restart followup #3783

Network restart followup #3783

Leo-Besancon commented Apr 6, 2023 •

edited

Loading

Eitu33 commented Jun 1, 2023

AurelienFT commented Jun 1, 2023

modship commented Jun 1, 2023

Network restart followup #3783

Network restart followup #3783

Conversation

Leo-Besancon commented Apr 6, 2023 • edited Loading

Eitu33 commented Jun 1, 2023

AurelienFT commented Jun 1, 2023

modship commented Jun 1, 2023

Leo-Besancon commented Apr 6, 2023 •

edited

Loading