Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all the determinism-sensitive crates have fixed versions #3899

Closed
AurelienFT opened this issue May 3, 2023 · 4 comments · Fixed by #3990 or #3783
Closed

Ensure that all the determinism-sensitive crates have fixed versions #3899

AurelienFT opened this issue May 3, 2023 · 4 comments · Fixed by #3990 or #3783
Assignees
@modship @Leo-Besancon

Comments

@AurelienFT
Copy link
Contributor

We can do it by adding an : = in front of the version numbers.
@damip
Copy link
Member

damip commented May 3, 2023 •
edited by Leo-Besancon
Loading

Determinism-sensitive crates:

  • rand in massa-pos-worker
  • rand_distr in massa-pos-worker
  • rand_xoshiro in massa-pos-worker
  • blake3 in massa-hash
  • bs58 in massa-hash
  • ed25519-dalek in massa-signature
  • bs58 in massa-signature
  • nom everywhere
  • the future state merkle tree crate (lsmtree = "0.1.1" in massa-db) of #3783 (files)

@damip
Copy link
Member

damip commented May 3, 2023

@dr-chain FYI

@modship modship self-assigned this May 26, 2023
@modship
Copy link
Member

modship commented May 26, 2023

@damip what about rand in massa-signature ?

@modship modship mentioned this issue May 26, 2023
Merged
16 tasks
This was linked to pull requests May 26, 2023
fix versions for determinist sensitive crates #3990
Merged
Network restart followup #3783
Merged
@modship
Copy link
Member

modship commented May 31, 2023 •
edited
Loading

@Leo-Besancon can you fix lsmtree crate version on your PR #3783 ?

@modship modship mentioned this issue Jun 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modship modship

@Leo-Besancon Leo-Besancon

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@modship @damip @Leo-Besancon @AurelienFT