Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix versions for determinist sensitive crates #3990

Merged
merged 3 commits into from
May 31, 2023
Merged

fix versions for determinist sensitive crates #3990

merged 3 commits into from
May 31, 2023

Conversation

modship
Copy link
Member

@modship modship commented May 26, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

part of #3899

#3899 (comment)

Determinism-sensitive crates:

@modship modship linked an issue May 26, 2023 that may be closed by this pull request
Ensure that all the determinism-sensitive crates have fixed versions #3899
Closed
@modship
Copy link
Member Author

modship commented May 26, 2023

#3899 (comment)

damip
damip reviewed May 30, 2023
View reviewed changes
massa-models/Cargo.toml Outdated Show resolved Hide resolved
damip
damip reviewed May 30, 2023
View reviewed changes
massa-models/Cargo.toml Outdated Show resolved Hide resolved
@damip
Copy link
Member

damip commented May 30, 2023 •
edited
Loading

  • yes, the version of the future merkle tree needs to be fixed
  • let's not fixate rand in massa-signature

@modship modship requested a review from damip May 30, 2023 12:01
@modship modship merged commit 279933b into testnet_23 May 31, 2023
@modship modship deleted the determinism_sensitive_crates_fixed_versions branch May 31, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that all the determinism-sensitive crates have fixed versions
2 participants
@modship @damip