Ben/boot loop ctrlc hotfix #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ben-PH
commented
May 10, 2023
•
Ben-PH
commented
- document all added functions
- try in sandbox /simulation/labnet
- unit tests on the added/changed features
- make tests compile
- make tests pass
- add logs allowing easy debugging in case the changes caused problems
- if the API has changed, update the API specification
|
status: running tests locally. Ran it on testnet: bootstrapped fine, handled ctrl-c fine. |
25 tasks
|
...also upgrades the bootstrap error messages a touch |
AurelienFT
approved these changes
May 11, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
May 12, 2023
3931: Ben/boot loop ctrlc hotfix r=AurelienFT a=Ben-PH * [ ] document all added functions * [x] try in sandbox /simulation/labnet * [x] unit tests on the added/changed features * [x] make tests compile * [x] make tests pass * [ ] add logs allowing easy debugging in case the changes caused problems * [ ] if the API has changed, update the API specification Co-authored-by: Ben PHL <benphawke@gmail.com>
|
Build failed: |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.