Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean event polling bootstrap - Windows routability #4084

Merged
merged 10 commits into from
Jun 14, 2023
Merged

Clean event polling bootstrap - Windows routability #4084

merged 10 commits into from
Jun 14, 2023

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

The goal of this PR was to clean up some event polling for Bootstrap listener, in order to resolve routability issues on Windows.
It is currently running on one testnet bootstrap server and seems to be doing fine (no signs of regressions), but I'll keep monitoring what's happening.

@Leo-Besancon Leo-Besancon changed the title Clean event polling bootstrap Clean event polling bootstrap - Windows routability Jun 14, 2023
Ben-PH
Ben-PH previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@Ben-PH Ben-PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work.

massa-bootstrap/src/server.rs Outdated Show resolved Hide resolved
massa-bootstrap/src/server.rs Outdated Show resolved Hide resolved
massa-bootstrap/src/listener.rs Outdated Show resolved Hide resolved
massa-bootstrap/src/listener.rs Show resolved Hide resolved
@Leo-Besancon Leo-Besancon requested a review from Ben-PH June 14, 2023 12:53
Ben-PH
Ben-PH previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@Ben-PH Ben-PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. My comments are for consideration, and don't block a merge.

massa-bootstrap/src/listener.rs Show resolved Hide resolved
massa-bootstrap/src/listener.rs Outdated Show resolved Hide resolved
massa-bootstrap/src/listener.rs Show resolved Hide resolved
@Ben-PH Ben-PH mentioned this pull request Jun 14, 2023
Merged
7 tasks
AurelienFT
AurelienFT approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve to unlock merge

@AurelienFT
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 14, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@Leo-Besancon Leo-Besancon merged commit d143727 into main Jun 14, 2023
@Leo-Besancon Leo-Besancon mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

@Ben-PH Ben-PH Ben-PH left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leo-Besancon @AurelienFT @Ben-PH