Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap/no opt waker #4086

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Bootstrap/no opt waker #4086

merged 5 commits into from
Jun 21, 2023

Conversation

Ben-PH
Copy link
Contributor

@Ben-PH Ben-PH commented Jun 14, 2023 •
edited
Loading

blocked pending #4084

implements many of the changes from #3964, reverting the cond-var uses.

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Ben-PH Ben-PH added blocked Issues that can't be done for now. bootstrap Issues related to the bootstrap labels Jun 14, 2023
@Ben-PH Ben-PH self-assigned this Jun 14, 2023
@Ben-PH Ben-PH requested review from modship and removed request for modship June 14, 2023 15:11
@Ben-PH Ben-PH marked this pull request as ready for review June 19, 2023 15:17
@Ben-PH Ben-PH requested a review from modship June 19, 2023 15:17
@Ben-PH Ben-PH removed the blocked Issues that can't be done for now. label Jun 19, 2023
@Ben-PH Ben-PH removed the request for review from modship June 19, 2023 15:33
@Ben-PH Ben-PH mentioned this pull request Jun 19, 2023
Closed
7 tasks
@Ben-PH Ben-PH requested a review from modship June 19, 2023 16:01
modship
modship approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@modship modship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's better without the Option for the stopper

@Ben-PH Ben-PH merged commit 185f93e into testnet_24 Jun 21, 2023
@AurelienFT AurelienFT deleted the bootstrap/no-opt-waker branch October 23, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modship modship modship approved these changes

Assignees

@Ben-PH Ben-PH

Labels
bootstrap Issues related to the bootstrap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ben-PH @modship